Skip to content

fix: Ignore readonly on select#4786

Merged
rjsparks merged 1 commit into
ietf-tools:mainfrom
larseggert:fix-select-readonly
Nov 23, 2022
Merged

fix: Ignore readonly on select#4786
rjsparks merged 1 commit into
ietf-tools:mainfrom
larseggert:fix-select-readonly

Conversation

@larseggert

Copy link
Copy Markdown
Collaborator

This was caused by #4708

@jennifer-richards jennifer-richards left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, I'd overlooked that a select really is not supposed to have a readonly attribute. I think this change is fine, pragmatically, but it'd perhaps be better to replace this hack [edit: meaning the one in #4708] with a better fix. Standard suggestion is to disable the select and add a hidden input to pass the value back to the form.

That'll take some nontrivial work, though, so I'd be fine with committing this and creating a ticket to clean things up.

Unless HTML 5 has changed the landscape - have not looked deeply into it.

@rjsparks rjsparks merged commit cb2f4af into ietf-tools:main Nov 23, 2022
@larseggert larseggert deleted the fix-select-readonly branch November 24, 2022 08:48
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Nov 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants